Skip to content

Allow aggregations to work with multi-tab. #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2023
Merged

Allow aggregations to work with multi-tab. #7212

merged 5 commits into from
Apr 12, 2023

Conversation

ehsannas
Copy link
Contributor

Fixes #7198.

A proper long-term solution for multi-tab should be implemented.

@ehsannas
Allow aggregations to work with multi-tab.
d6255b9 
Fixes #7198.

A proper long-term solution for multi-tab should be implemented.
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 77c143c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ehsannas ehsannas requested review from dconeybe and wu-hui April 12, 2023 19:42
dconeybe
dconeybe approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments about the change log entry.

@dconeybe
Copy link
Contributor

@milaGGL as FYI since she implemented this feature.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 12, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (8c44d58)Merge (be6a323)Diff
    browser278 kB278 kB-120 B (-0.0%)
    esm5346 kB346 kB-195 B (-0.1%)
    main554 kB554 kB-203 B (-0.0%)
    module278 kB278 kB-120 B (-0.0%)
    react-native279 kB279 kB-120 B (-0.0%)

  • firebase

    TypeBase (8c44d58)Merge (be6a323)Diff
    firebase-firestore.js327 kB327 kB-122 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sXkPxtuVab.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 12, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • getAggregateFromServer

      Size

      TypeBase (8c44d58)Merge (be6a323)Diff
      size107 kB107 kB-173 B (-0.2%)
      size-with-ext-deps166 kB166 kB-175 B (-0.1%)

      Dependency

      TypeBase (8c44d58)Merge (be6a323)Diff
      functions

      141 dependencies

      $
$s
$t
Aa
As
Bc
Be
Bs
C
Ca
Ce
Ci
Cs
De
Di
Ds
Ea
Ec
En
Es
F
Fe
Fs
Fu
Ge
Gn
Ha
He
Hi
Hn
In
Je
Ji
Jn
Ke
Ki
Kn
Le
Ln
Ls
Mt
Mu
N
Ne
Ni
Nn
Ns
O
Pi
Pu
Qa
Qi
Qn
Qs
Qu
Ra
S
Sa
Se
Ts
Tu
Ue
Ui
Un
Us
Ve
Vs
Vt
Vu
Wa
We
Wi
Wo
X
Xi
Xn
Y
Yc
Ye
Yi
Yn
Zc
Ze
Zn
_e
_h
_n
an
as
ba
bi
bn
bs
cc
cn
cs
df
es
fc
gn
gs
gt
hr
hs
je
ji
jn
jo
js
k
kn
ku
ln
ls
me
mh
ms
mt
ns
oi
pn
pt
qe
qn
rs
tt
uc
us
va
vi
we
ws
x
xe
xn
yn
ys
ze
zi
zn
zs

      140 dependencies

      $
$s
$t
Aa
As
Bc
Be
Bs
C
Ca
Ce
Ci
Cs
De
Di
Ds
Ea
Ec
En
Es
F
Fe
Fs
Fu
Ge
Gn
Ha
He
Hi
Hn
In
Je
Ji
Jn
Ke
Ki
Kn
Le
Ln
Ls
Mt
Mu
N
Ne
Ni
Nn
Ns
O
Pi
Pu
Qa
Qi
Qn
Qs
Qu
Ra
S
Se
Ts
Tu
Ue
Ui
Un
Us
Ve
Vs
Vt
Vu
Wa
We
Wi
Wo
X
Xi
Xn
Y
Yc
Ye
Yi
Yn
Zc
Ze
Zn
_e
_h
_n
an
as
ba
bi
bn
bs
cc
cn
cs
df
es
fc
gn
gs
gt
hr
hs
je
ji
jn
jo
js
k
kn
ku
ln
ls
me
mh
ms
mt
ns
oi
pn
pt
qe
qn
rs
tt
uc
us
va
vi
we
ws
x
xe
xn
yn
ys
ze
zi
zn
zs

      - Sa

    • getCountFromServer

      Size

      TypeBase (8c44d58)Merge (be6a323)Diff
      size107 kB107 kB-173 B (-0.2%)
      size-with-ext-deps166 kB166 kB-175 B (-0.1%)

      Dependency

      TypeBase (8c44d58)Merge (be6a323)Diff
      functions

      143 dependencies

      $
$s
$t
Aa
As
Bc
Be
Bs
C
Ca
Ce
Ci
Cs
De
Di
Ds
Ea
Ec
En
Es
F
Fe
Fs
Fu
Ge
Gn
Ha
He
Hi
Hn
In
Je
Ji
Jn
Ke
Ki
Kn
Le
Ln
Ls
Mt
Mu
N
Ne
Ni
Nn
Ns
O
Pi
Pu
Qa
Qi
Qn
Qs
Qu
Ra
S
Sa
Se
Ts
Tu
Ue
Ui
Un
Us
Ve
Vs
Vt
Vu
Wa
We
Wi
Wo
X
Xi
Xn
Y
Yc
Ye
Yi
Yn
Zc
Ze
Zn
_e
_h
_n
an
as
ba
bi
bn
bs
cc
cn
cs
df
es
fc
ff
gn
gs
gt
hr
hs
je
ji
jn
jo
js
k
kn
ku
ln
ls
me
mh
ms
mt
ns
oi
pn
pt
qe
ql
qn
rs
tt
uc
us
va
vi
we
ws
x
xe
xn
yn
ys
ze
zi
zn
zs

      142 dependencies

      $
$s
$t
Aa
As
Bc
Be
Bs
C
Ca
Ce
Ci
Cs
De
Di
Ds
Ea
Ec
En
Es
F
Fe
Fs
Fu
Ge
Gn
Ha
He
Hi
Hn
In
Je
Ji
Jn
Ke
Ki
Kn
Le
Ln
Ls
Mt
Mu
N
Ne
Ni
Nn
Ns
O
Pi
Pu
Qa
Qi
Qn
Qs
Qu
Ra
S
Se
Ts
Tu
Ue
Ui
Un
Us
Ve
Vs
Vt
Vu
Wa
We
Wi
Wo
X
Xi
Xn
Y
Yc
Ye
Yi
Yn
Zc
Ze
Zn
_e
_h
_n
an
as
ba
bi
bn
bs
cc
cn
cs
df
es
fc
ff
gn
gs
gt
hr
hs
je
ji
jn
jo
js
k
kn
ku
ln
ls
me
mh
ms
mt
ns
oi
pn
pt
qe
ql
qn
rs
tt
uc
us
va
vi
we
ws
x
xe
xn
yn
ys
ze
zi
zn
zs

      - Sa

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N1pC98JGS8.html

@ehsannas ehsannas merged commit b66908d into master Apr 12, 2023
@ehsannas ehsannas deleted the ehsann/fix-count-multitab branch April 12, 2023 21:32
@google-oss-bot google-oss-bot mentioned this pull request Apr 13, 2023
Merged
@firebase firebase locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to get aggregate result because the client is offline
4 participants
@ehsannas @dconeybe @google-oss-bot @wu-hui